Removes non-regular files from file count #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdstein
requested review from
dotNomad,
kgartland-rstudio,
mmarchetti and
sagerb
as code owners
mmarchetti
approved these changes
Sep 12, 2023
|
@kgartland-rstudio - I'm going to go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
The current count includes non-regular files. Generally, when users refer to files, they are referring to regular files. Not directories, symlinks, and other types of non-regular files.
Closes #166
Type of Change
Approach
Filters the count to regular files.
Automated Tests
Leverages existing automated tests.
Directions for Reviewers
Validate that the count shown in the UI matches expectations.
Checklist