Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gifs to feature sections in extension README #2395

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Add gifs to feature sections in extension README #2395

merged 2 commits into from
Oct 18, 2024

Conversation

dotNomad
Copy link
Collaborator

Broke this off from #2352 easier review. This adds gifs to the different feature sections to highlight them:

  • "Start in VS Code or Positron and end with content on Posit Connect"
    • Shows the flow of creating a deployment, reviewing it, and sending it up
  • "Deployment logs"
    • Shows the Deployment logs through a deployment

Intent

Part of #2024

Type of Change

    • Bug Fix
    • New Feature
    • Breaking Change
    • Documentation
    • Refactor
    • Tooling

@sagerb sagerb marked this pull request as ready for review October 17, 2024 22:59
sagerb
sagerb approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@sagerb sagerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't see any updates needed per the latest changes in the release.

@sagerb sagerb merged commit e2a5354 into dotnomad/improved-readme Oct 18, 2024
14 checks passed
@sagerb sagerb deleted the dotnomad/readme-gifs branch October 18, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagerb sagerb sagerb approved these changes

@kgartland-rstudio kgartland-rstudio Awaiting requested review from kgartland-rstudio

@marcosnav marcosnav Awaiting requested review from marcosnav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dotNomad @sagerb