Remove R Package Scan action #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagerb
requested review from
dotNomad,
kgartland-rstudio and
marcosnav
as code owners
sagerb
commented
Oct 18, 2024
| @@ -60,7 +60,6 @@ const pythonPackagesCommands = { | |||
| const rPackagesCommands = { | |||
| Edit: "posit.publisher.rPackages.edit", | |||
| Refresh: "posit.publisher.rPackages.refresh", | |||
| Scan: "posit.publisher.rPackages.scan", | |||
| } as const; | |||
There was a problem hiding this comment.
This removes the "eye" icon from the R Packages view expanded toolbar.
sagerb
commented
Oct 18, 2024
| "title": "Scan for R Packages", | ||
| "icon": "$(eye)", | ||
| "category": "Posit Publisher" | ||
| }, |
There was a problem hiding this comment.
This removes the high-level internal command from the extension.
sagerb
commented
Oct 18, 2024
| Commands.RPackages.Scan, | ||
| this.onScanForRPackageRequirements, | ||
| this, | ||
| ), |
There was a problem hiding this comment.
no longer register a handler for the scan command that we removed.
sagerb
commented
Oct 18, 2024
| <vscode-button @click="onScanForPackageRequirements()"> | ||
| Scan | ||
| </vscode-button> | ||
| </template> |
There was a problem hiding this comment.
This was basically the same as above, so it's been consolidated.
sagerb
commented
Oct 18, 2024
| uriPath: "https://rstudio.github.io/renv/articles/renv.html", | ||
| }, | ||
| }); | ||
| }; |
There was a problem hiding this comment.
This new code is invoked when the user clicks on the anchor we added.
kgartland-rstudio
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
- Mismatched package versions in
renv.lockand library - R Section shows proper warning when missing
renv.lock - R Section shows proper warning when missing
renv/activate.R - R Section respects Package file listed and uses the proper filename in new warn text
- renv link works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Resolves #2403
Type of Change
Approach
Removed ability to scan from HomeView. This eliminates the original error shown, which was exposed from invalid
renvenvironment.Consolidated some errors to show consistently, and then replaced scan button with anchor link to
renvdocumentation.Updated documentation.
Directions for Reviewers
Verify:
renv.lockfile in place (and activerenvenvironment)renvdoc, when package file is not present (missing or empty). Name of package file should match what is in config. Anchor should openrenvdocumentation.Checklist