Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Jupyter hide options in Connect manifest #2409

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

dotNomad
Copy link
Collaborator

This PR adds the two rendering options for Jupyter available in the Connect manifest:

  • hide_all_input which hides all of the input cells on render
  • hide_tagged_input hides the input cells marked hide_input

See the documentation for rsconnect-jupyter for more information: https://docs.posit.co/rsconnect-jupyter/usage/#hide-input

After merging we will need to update the schema on the CDN.

Intent

Resolves #2399

Type of Change

    • Bug Fix
    • New Feature
    • Breaking Change
    • Documentation
    • Refactor
    • Tooling

Approach

We already had the types for the Manifest, and were aware of these issues, but our Configuration didn't have a way to set / pass through those options.

Here I'm using the same technique for R, Python, and Quarto configuration settings to create the manifest.

Automated Tests

Added automated tests around the new manifest creation code.

Directions for Reviewers

Deploy a Jupyter Notebook:

  • without using the new render options
  • using hide_all_input
  • using hide_tagged_input

Copy link
Collaborator

@kgartland-rstudio kgartland-rstudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@marcosnav marcosnav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@dotNomad dotNomad merged commit fdc5cc0 into main Oct 28, 2024
14 checks passed
@dotNomad dotNomad deleted the dotnomad/support-jupyter-hide-options branch October 28, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jupyter Deployment without displaying code
3 participants