Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow type: 'unknown' in our Configuration schema #2423

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

dotNomad
Copy link
Collaborator

@dotNomad dotNomad commented Nov 8, 2024

This PR does two things:

  • Adds type = 'unknown' to our schema making it a valid option in our Configuration files
  • Allows changing the type from unknown to something else and re-deploying
    • Changing types if the previous type is not unknown is still invalid

Consequences of this PR

With type = 'unknown' now passing schema validation for our Configuration files, when Config has that type:

  • We lose the sidebar warning showing the user that the config is in error
  • We lose TOML validation warnings if the user is using an extension like Even Better TOML
  • Actions like including or excluding files can now be done
  • When deploying the content, it now gets created on Connect, as opposed to failing a pre-check in Publisher. Connect communicates that failure with "“Cannot process manifest: Unrecognized app mode”"
    • This can be addressed by the user by changing the type to something that produces a valid App Mode (anything but unknown) and re-deploying due to the 2nd change mentioned above

Intent

Further addresses #2419 and allows more actions on the Configuration file from sidebar when the Configuration type = 'unknown'

Type of Change

  • Refactor

Automated Tests

I did add an automated test to check that moving from App Mode "" (or type = 'unknown') to a valid App Mode was acceptable in our deployment pre-checks.

@dotNomad dotNomad changed the title Allow type: 'unknown' in our schema Allow type: 'unknown' in our Configuration schema Nov 8, 2024
@dotNomad dotNomad force-pushed the dotnomad/unknown-type branch from 4bc4009 to bcbcc1b Compare November 12, 2024 18:30
Base automatically changed from dotnomad/unknown-type-creation to main November 12, 2024 18:51
@dotNomad dotNomad merged commit 42d9316 into main Nov 12, 2024
14 checks passed
@dotNomad dotNomad deleted the dotnomad/unknown-type branch November 12, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants