-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable detection and deployment of Quarto scripts #2424
Conversation
… name, quarto -> quarto-static
896232e
to
dc97e2a
Compare
dc97e2a
to
3112888
Compare
Oh interesting! Is this true on Connect as well? If yes, is that documented anywhere? I went looking for this specifically and honestly couldn't even find that script ->
I can RTFS / RTFPR, but is this validation still blocking a deployment or have we lifted that restriction and it's only an advisory "this isn't in the schema I know about"? |
Yes, that is how Connect identifies this content type. We use Worth noting that for other types we have this kind of specificity, for example:
There is a slight mention about ...but the full list of types can be found on API docs, specifically the endpoints related to the content schema It is not common for the user to determine the content type before hand, until now with Publisher. Previously, Connect would determine the type of content based on the bundle uploaded and deployed. Seems the publisher is the first tool making use of the content type identifier, in this case within the configuration toml, before pushing any bundle to Connect. I mention this because this seem to me to be the reason why the content type enumeration is not that prominent in the docs. |
I just double checked this, and you should be able to do deployments, the TOML schema linting will throw warnings until the PR lands, but that's all |
nods I did find this, and there is no mention of
OH OH OH. I read this backwards, sorry! I looked at the code and see that this is changing where the publisher code used to just use |
Oh got it, thanks for the comment I updated the PR description to be more clear about this 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested our Quarto content in the sample-content
directory which includes a plain Quarto file plus R and Python runtime examples.
I also tested the examples in the rendered scripts docs. Everything deployed beautifully.
I also like the change to quarto-static
to match Connect and all the testing you did here 👍
Fantastic work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait I'm realizing that internal/schema/schemas/posit-publishing-schema-v3.json
does not contain the change from quarto
to quarto-static
. Shouldn't that be included?
Marking as "request changes" just to be sure since I approved already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the type section under General settings also needs an update
🤦 Nope I just can't read the files list in GitHub PRs apparently. Both of these files contain the There are two open questions I have:
|
After a quick discussion in stand-up:
I'll start adding that to my PR #2426 |
Support deprecated `quarto` type
Thanks @dotNomad ! Merged #2426 into this PR, absolutely needed those changes.
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for merging in my branch, and for the work on this PR I think it is looking great!
Compare AppMode in pre-check not ContentType
Intent
This PR introduces a few changes required to allow Python and R files to be considered as entrypoints for Quarto rendered scripts.
Also, renaming the content type from
quarto
toquarto-static
on many places to avoid future confusion, since Connect handles the type asquarto-static
, within publisher code we should try to stick toquarto-static
as well.Fixes #1208
Type of Change
Automated Tests
Directions for Reviewers
This can be tested using the jumpstart examples "Quarto Script Python" and "Quarto Script R", choosing the
.py
and.R
files should create the project configuration toml withtype = "quarto-static"
.Deployment should work too, TOML schema validations might show warnings until this PR is merged and the updated schema JSON file, that now includes
quarto-static
as a valid type, landsmain
.Checklist