Add emphasis to entrypoint TreeItem in Files #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotNomad
requested review from
kgartland-rstudio,
sagerb and
marcosnav
as code owners
jonkeane
reviewed
Nov 14, 2024
Comment on lines
+88
to
+94
| const isEntrypoint = (file: ContentRecordFile): boolean => { | ||
| const config = home.selectedConfiguration; | ||
| if (config != undefined && !isConfigurationError(config)) { | ||
| return file.id === config.configuration.entrypoint; | ||
| } | ||
| return false; | ||
| }; |
There was a problem hiding this comment.
Oh, nice. It's nice that this code is closer to the actual display as well — keeps the logic closer to the thing that uses it.
I wonder why we thought we required this to come from the backend in the first place?
There was a problem hiding this comment.
I wonder why we thought we required this to come from the backend in the first place?
I don't quite recall, but I think we have a tendency to move logic to the backend if we do (or would) repeat it a lot on the display side. This may have been one of those we made the judgement too early calls and we didn't actually need isEntrypoint all that much.
marcosnav
approved these changes
Nov 15, 2024
Validation screenshot (entrypoint highlighted)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to emphasize our Tree Item components with a new
listStyleprop option, then uses that to emphasize the entrypoint.Intent
Resolves #2239
Type of Change
Approach
The approach was to use a CSS variable provided by VS Code, in this case
--vscode-list-activeSelectionForeground. This is the same color as the active file when looking at the Explorer.User Impact
This provides the user a bit of glanceability to the understand what the "main"/entrypoint file is when looking at the Project Files view. It reinforces the most important file being deployed.
This is particularly helpful if the folder has multiple deployments with multiple entrypoints.
This option of using the same color as the active file in the Explorer view may be a bit confusing since our Project Files looks a bit like the Explorer pane, and has the "open file" icon button. This is opened as a draft to discuss this.