Address ESLint errors from recommended plugins

[dotNomad]

This PR is a follow-up to #2440 that addresses all of the new rules that are failing.

Intent

Resolves #1293

Type of Change

• • Bug Fix
• • New Feature
• • Breaking Change
• • Documentation
• • Refactor
• • Tooling

Approach

Rather than change every any I figured we could make a follow-up issue to remove the // eslint-disable-next-line @typescript-eslint/no-explicit-any added here since those are a bit complex.

The work I did do here that wasn't auto-fixed was removed the async promise executors. To see why this is recommended I suggest reading the no-async-promise-executor rule docs: https://eslint.org/docs/latest/rules/no-async-promise-executor

Directions for Reviewers

Test the changed code in the following flows:

• New Deployment flows
• Selecting a New or Existing Config
• The home view's handleFileInitiatedDeploymentSelection which fires when the entrypoint button is pressed

Most everything else is disabling any rules and changing to const where applicable.

[marcosnav]

Nice! It catched a lot of things!

[dotNomad]

Nice! It catched a lot of things!

Yeah I'm really happy to get these recommended rules in to catch things like this!