Disable entrypoint checkbox in Project Files view #2487
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotNomad
force-pushed
the
dotnomad/disable-entrypoint-checkbox
branch
from
f9a03ca to
c6c7552
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the user from unchecking the entrypoint checkbox (and therefor removing the entrypoint from the
filesattribute in their configuration).The configuration can still be edited by hand, but the sidebar no longer allows getting into this bad state.
Intent
Part of #1493
Type of Change
User Impact
The user will no longer be able to uncheck the entrypoint's checkbox.
Directions for Reviewers
Ensure that the entrypoint, no matter the details in the configuration, can be unchecked.
Checking the entrypoint checkbox should still be available if the configuration is manually edited and the entrypoint needs to be added.