-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python on path #258
Python on path #258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible that you need to change the base of this PR, as it seems to include a lot more than just support for finding python or python3? Otherwise, if this is what you intended, you should update the description and get validation instructions in there for the other changes.
I suspect this isn't quite ready but I just grabbed the binary from GH Actions and it's still failing when I don't have a python3.exe. Here's a gif of what's I'm seeing when using this build: The error when there is no
PYTHONPATH=C:\Users\kgartland\AppData\Local\Programs\Python\Python311 |
Verifed fix! New build works with no |
This PR changes how we handle finding the active Python executable, if one isn't specified.
We previously tried to find
python
onPATH
; this PR adds a fallback topython
since some installs do not include an executable namedpython3
.Intent
Fixes #172
Type of Change
Automated Tests
There are unit tests covering this change.
Directions for Reviewers
Re-test the Windows scenario in #172 and verify that if
python
is on PATH butpython3
is not, we use thepython
executable.