Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ESLint configuration for Cypress #295

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

tdstein
Copy link
Collaborator

@tdstein tdstein commented Oct 18, 2023

Intent

Adds ESLint to Cypress package.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change

Approach

Automated Tests

Directions for Reviewers

Checklist

@tdstein tdstein marked this pull request as ready for review October 18, 2023 15:54
@tdstein
Copy link
Collaborator Author

tdstein commented Oct 18, 2023

@dotNomad - this is a duplicate of the previous one.

Copy link
Collaborator

@dotNomad dotNomad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting my same comments from the previous PR #293

This gives us linting Cypress which is great, and uses the Cypress ESLint Plugin 🎉
Left a note about missing the same ESLint config from web if that matters for us.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great because it extends the Cypress ESLint plugin and enables the Cypress globals for linting, however if we care about linting all of our JS / TS files the same we are missing all of the rules and plugins from publishing-client/web/.eslintrc.cjs. Granted not all of those rules are applicable since this doesn't use Vue and are no longer using TypeScript here.

@tdstein tdstein merged commit 5ff5ba2 into main Oct 20, 2023
11 checks passed
@tdstein tdstein deleted the tdstein/eslint-cypress-fix branch October 20, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants