-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: publishing metadata document schema #318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pushing this along. A few comments and questions here.
} | ||
} | ||
}, | ||
"connect": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be nested inside a generic container, such that other (theoretical) consumers could add their own settings objects? In general, do we allow attributes that are not declared in this schema (I assume so), and where do we document how consumers should interpret this (i.e., this is the spec, but you aren't prevented from looking for additional fields)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, this schema does not set additionalAttributes: true
anywhere, because doing so allows a wide range of invalid constructs and typos to pass validation. We can update the schema as features are added to the deployment servers.
Since we only have 2 supported deployment servers, I was intending to give each one a named section for server-type-specific attributes. These sections would be specified in the schema like any other, but ignored by other types of servers. It's reasonable to group them under a parent heading.
…ient into mm-metadata-schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge this as a base for us to iterate on.
Q: should we produce a subset schema containing only what's currently supported by the client? That would allow us to differentiate what's a draft for review (easy and cheap to change) from what has code behind it (more expensive to change). |
This sounds like a good change to me. |
Map schema content types to Connect ones
For discussion, a JSON Schema of what it would look like to formalize the options and settings required to publish content to Connect et al. such that it could be checked into source control and drive publishing.