-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extra cli args #349
Remove extra cli args #349
Conversation
This reverts commit e488074.
New output from
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
You should be able to remove the |
This PR broke deployment of python content because it removes the inspection step that creates the python section in the manifest. Added a commit to fix that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Remove Kong tags from everything that's not a CLI argument in the new workflow.
Move AccountName from a state field to a command field.
Remove DeployedAt from the saved target data.
Automated Tests
Updated existing unit tests.
Directions for Reviewers
CI should pass. Moving toward the new data model in pieces, so there's still a lot that's not there yet.