Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra cli args #349

Merged
merged 8 commits into from
Nov 27, 2023
Merged

Conversation

mmarchetti
Copy link
Contributor

Remove Kong tags from everything that's not a CLI argument in the new workflow.
Move AccountName from a state field to a command field.
Remove DeployedAt from the saved target data.

Automated Tests

Updated existing unit tests.

Directions for Reviewers

CI should pass. Moving toward the new data model in pieces, so there's still a lot that's not there yet.

@mmarchetti
Copy link
Contributor Author

New output from connect-client publish --help:

Usage: connect-client-0.0.dev2-43-g378b0b89-darwin-amd64 publish <path>

Arguments:
  <path>    Path to directory containing files to publish, or a file within that directory.

Flags:
  -h, --help                   Show context-sensitive help.
      --debug                  Enable debug mode ($CONNECT_DEBUG).
      --token=TOKEN            Authentication token for the publishing UI. Default auto-generates a token.
      --version                Show the client software version and exit.

  -n, --account-name=STRING    Nickname of destination publishing account.
  -c, --config=STRING          Configuration file name (in .posit/publish/). Default is deploy.toml.
      --new                    Create a new deployment instead of updating the previous deployment.

Copy link
Collaborator

@tdstein tdstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tdstein
Copy link
Collaborator

tdstein commented Nov 13, 2023

You should be able to remove the --token flag now that my change to remove authentication is on main.

@mmarchetti
Copy link
Contributor Author

This PR broke deployment of python content because it removes the inspection step that creates the python section in the manifest. Added a commit to fix that.

Copy link
Collaborator

@kgartland-rstudio kgartland-rstudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mmarchetti mmarchetti merged commit eb10e99 into mm-remove-unused-commands Nov 27, 2023
17 checks passed
@mmarchetti mmarchetti deleted the mm-remove-extra-cli-args branch November 27, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants