Map schema content types to Connect ones #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmarchetti
requested review from
dotNomad,
kgartland-rstudio,
sagerb and
tdstein
as code owners
tdstein
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Fixes #397
Type of Change
Approach
Created a new type for the Type field in the configuration. The content type inspector now returns this type instead of a Connect-specific apptypes.AppMode. There is a map to translate these into the Connect AppMode when we create the manifest for a Connect deployment.
Automated Tests
The changed code is covered by unit tests, which have been updated to look for the schema-defined types.
Directions for Reviewers
Deploy content to Connect where the internal (schema-defined) type doesn't match the string that Connect uses, e.g. a Jupyter notebook.