Add Quarto Tests to the Nightly deployments #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgartland-rstudio
requested review from
dotNomad,
mmarchetti,
sagerb and
tdstein
as code owners
mmarchetti
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
FIxes: #955
This adds the supported Quarto types to our deployment tests and asserts for the proper error on the unsupported Quarto types.
Type of Change
Approach
I had to create a new AMI that had Quarto installed on it for these tests. Then added my a test environment file to each of the quarto content types in the connect-content repo for them to run against. I added an array of currently un-supported Quarto types so we can test the proper error output. This also adds a Quarto install on the GH Actions boxes prior to the tests.
Only one Quarto content failed unexpectedly:
#954
Automated Tests
these are them.
Directions for Reviewers
The tests are working and deploying quarto:
https://github.com/posit-dev/publisher/actions/runs/7761257988
Checklist