Skip to content

Commit

Permalink
QA fixes for components/templates (#150)
Browse files Browse the repository at this point in the history
* Make select single match core (ui.page_fixed)

* remove comment in code

* change valuebox preview to image
  • Loading branch information
gregswinehart authored May 30, 2024
1 parent bc3db2e commit 01add84
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 10 deletions.
2 changes: 1 addition & 1 deletion components/inputs/select-single/app-core.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from shiny import App, render, ui

app_ui = ui.page_fluid(
app_ui = ui.page_fixed(
ui.input_select( # <<
"select", # <<
"Select an option below:", # <<
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
"Up 30% VS PREVIOUS 30 DAYS",
showcase=faicons.icon_svg("piggy-bank", width="50px"),
theme="bg-gradient-indigo-purple", # <<
full_screen=True,
),
ui.value_box(
"KPI Title",
Expand All @@ -18,7 +17,6 @@
showcase=faicons.icon_svg("piggy-bank", width="50px"),
theme="text-green", # <<
showcase_layout="top right", # <<
full_screen=True,
),
ui.value_box(
"KPI Title",
Expand All @@ -27,7 +25,6 @@
showcase=faicons.icon_svg("piggy-bank", width="50px"),
theme="danger", # <<
showcase_layout="bottom", # <<
full_screen=True,
),
)
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
with ui.value_box(
showcase=faicons.icon_svg("piggy-bank", width="50px"),
theme="bg-gradient-indigo-purple", # <<
full_screen=True,
):
"KPI Title"
"$1 Billion Dollars"
Expand All @@ -15,7 +14,6 @@
showcase=faicons.icon_svg("piggy-bank", width="50px"),
theme="text-green", # <<
showcase_layout="top right", # <<
full_screen=True,
):
"KPI Title"
"$1 Billion Dollars"
Expand All @@ -25,7 +23,6 @@
showcase=faicons.icon_svg("piggy-bank", width="50px"),
theme="danger", # <<
showcase_layout="bottom", # <<
full_screen=True,
):
"KPI Title"
"$1 Billion Dollars"
Expand Down
4 changes: 2 additions & 2 deletions components/outputs/value-box/index.qmd
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
title: Value Box
sidebar: components
appPreview:
file: components/outputs/value-box/app-preview.py
preview: '<div class="p-0" style="overflow: hidden;border-radius:10px;"><p class="mb-0"><img style="width: auto;height:100%;max-height:150px;"
src="/images/valuebox.jpg"></p></div>'
listing:
- id: example
template: ../../_partials/components-detail-example.ejs
Expand Down
1 change: 0 additions & 1 deletion components/outputs/verbatim-text/app-express.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
# FIXME: Rewrite as an Express app
from shiny import render
from shiny.express import input, ui

Expand Down
Binary file added images/valuebox.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 01add84

Please sign in to comment.