Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express Release: Docs and site changes #64

Merged
merged 186 commits into from
Jan 29, 2024
Merged

Express Release: Docs and site changes #64

merged 186 commits into from
Jan 29, 2024

Conversation

gadenbuie
Copy link
Contributor

@gadenbuie gadenbuie commented Jan 12, 2024

Feature branch to collect all Express-related documentation and website updates.

For posit-dev/py-shiny#969

Dev Notes

  • Target any Express-related updates on this branch.
  • Please prefer leaving commit history in tact and using merge commits. Alternatively use PR branch for git history revisions.

Previewing

The shinylive examples in the deployment previews use the current PyPi release of packages, but the examples and writing target the new release, so many of them will be broken. If you'd like to locally build the site with the latest versions of packages, do:

# First, make sure you can build shinylive
git clone https://github.com/posit-dev/shinylive
cd shinylive
make submodules
make all

# Link shinylive CLI to freshly built assets
pip install shinylive
shinylive assets link-from-local ./build

# Re-build with latest dev versions
cd packages
cd py-htmltools && git pull && cd ..
cd py-shiny && git pull && cd ..
cd py-shinywidgets && git pull && cd ..
cd py-faicons && git pull && cd ..
cd ..
make clean && make all

# Finally, build py-shiny-site from this branch
git clone https://github.com/posit-dev/py-shiny-site
cd py-shiny-site
git checkout rc-express
make serve

@github-actions github-actions bot temporarily deployed to pr-64 January 27, 2024 00:31 Destroyed
@github-actions github-actions bot temporarily deployed to pr-64 January 28, 2024 09:14 Destroyed
Copy link
Contributor

@gshotwell gshotwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, a few review comments which are optional

```

Adding a `ui.panel_sidebar` call around `ui.input_numeric` simply wraps the control with additional HTML (a `<div>` and `<form>`, in this case).
The nesting of the generated HTML matches the nesting of the Python function calls in your UI.
![The resulting dashboard generated by the dashboard template](assets/dashboard-template.png){class="img-shadow"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this screenshot matches the template so we should change the photo.

docs/express-vs-core.qmd Show resolved Hide resolved
docs/express-vs-core.qmd Outdated Show resolved Hide resolved
docs/express-vs-core.qmd Show resolved Hide resolved
docs/express-vs-core.qmd Outdated Show resolved Hide resolved
docs/express-vs-core.qmd Outdated Show resolved Hide resolved
However, that investment has its own payoff.

The bulk of the rest of this article will focus on the advantages of Shiny Core.
This isn't because we think it's better, but because Shiny Express's advantages---being more approachable and more concise---are fairly self-evident, while Shiny Core's advantages are more subtle.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This isn't because we think it's better, but because Shiny Express's advantages---being more approachable and more concise---are fairly self-evident, while Shiny Core's advantages are more subtle.
This isn't because we think it's better overall, but because Shiny Express's advantages---being more approachable and more concise---are fairly self-evident, while Shiny Core's advantages are more subtle.

docs/express-or-core.qmd Show resolved Hide resolved
docs/express-or-core.qmd Outdated Show resolved Hide resolved
docs/express-or-core.qmd Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr-64 January 28, 2024 22:31 Destroyed
Co-authored-by: Gordon Shotwell <[email protected]>
@github-actions github-actions bot temporarily deployed to pr-64 January 29, 2024 06:34 Destroyed
@gadenbuie gadenbuie marked this pull request as ready for review January 29, 2024 15:35
@github-actions github-actions bot temporarily deployed to pr-64 January 29, 2024 15:38 Destroyed
@github-actions github-actions bot temporarily deployed to pr-64 January 29, 2024 15:44 Destroyed
@gadenbuie

This comment was marked as resolved.

@github-actions github-actions bot temporarily deployed to pr-64 January 29, 2024 15:48 Destroyed
@github-actions github-actions bot temporarily deployed to pr-64 January 29, 2024 16:05 Destroyed
@github-actions github-actions bot temporarily deployed to pr-64 January 29, 2024 16:07 Destroyed
@github-actions github-actions bot temporarily deployed to pr-64 January 29, 2024 16:16 Destroyed
@cpsievert cpsievert merged commit 401b90f into main Jan 29, 2024
1 check passed
@cpsievert cpsievert deleted the rc-express branch January 29, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants