-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul "Learn Shiny" content to be Express focused #68
Conversation
05458d9
to
749e7d2
Compare
749e7d2
to
14b1a93
Compare
14b1a93
to
dd3cc6e
Compare
b140c4b
to
3b2aaca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got up to the ui sections. I think this is great, but the reactive programming stuff still seems like it's not quite right for people learning about reactivity for the first time. I think we should ship them because they're still a big improvement, but we may want to revisit them again fairly soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, one thing is that quite a lot of sentences start with some version of "it's often useful" or "it's sometimes useful". I think we can more or less get rid of all of these and just jump right into the content. I made some suggested changes, but flagged a few of them just to be revised. I think it's a good idea to use second person language in these cases "input.select is for when you want to select an input"
docs/ui-layouts.qmd
Outdated
|
||
### `page_navbar()` | ||
|
||
A multi-page application, with an optional sidebar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to say more about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh sorry, this was another file that should've been removed (we can lean on the layout gallery instead now).
3e0b8a8
to
1e18467
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry to say I really don't like the direction that the Motivate express article has gone in. My main concern with Express is that we want to avoid abandoning Shiny Core, and so we need a very clear article which articulates why people should still care about and use Shiny Core. Currently the Express-Core translation article reads more like "Here's why you might think you need Shiny Core but really Express does all of those things too", and includes much more express code than Core code. My suggestion is:
- Write a new article called "programming with express" that covers
@expressify
@hold
@render.express
and talks about managing complexity in Express. - Reference that article in a callout, but have this article be all about the virtues of Core.
If we don't have a clear articulation of why Core is good, Express looks a lot more like something that supersedes Core entirely than adjuvant syntax.
To preview locally (with the shinylive extension using the latest versions of packages):