Apply suggestions from code review

Co-authored-by: Carson Sievert <[email protected]>
posit-dev · Jan 24, 2024 · 4023397 · 4023397
1 parent 81f0314
commit 4023397
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 11 deletions.
diff --git a/shiny/api-examples/layout_column_wrap/app-express.py b/shiny/api-examples/layout_column_wrap/app-express.py
@@ -1,7 +1,8 @@
-import shiny
 from shiny.express import ui
 
-a_card = shiny.ui.card("A simple card")
+with ui.hold() as a_card:
+    with ui.card():
+        "A simple card"
 
 # Always has 2 columns (on non-mobile)
 with ui.layout_column_wrap(width=1 / 2):

diff --git a/shiny/api-examples/layout_columns/app-express.py b/shiny/api-examples/layout_columns/app-express.py
@@ -1,7 +1,6 @@
 from model_plots import *  # model plots and cards
 
-from shiny import render
-from shiny.express import input, ui
+from shiny.express import input, render, ui
 
 ui.page_opts(title="Model Dashboard")
 

diff --git a/shiny/api-examples/layout_sidebar/app-express.py b/shiny/api-examples/layout_sidebar/app-express.py
@@ -1,8 +1,7 @@
 import matplotlib.pyplot as plt
 import numpy as np
 
-from shiny import render
-from shiny.express import input, ui
+from shiny.express import input, render, ui
 
 with ui.layout_sidebar():
     with ui.sidebar():

diff --git a/shiny/api-examples/markdown/app-express.py b/shiny/api-examples/markdown/app-express.py
@@ -1,4 +1,4 @@
-from shiny.express import input, ui
+from shiny.express import ui
 
 ui.markdown(
     """

diff --git a/shiny/api-examples/page_sidebar/app-express.py b/shiny/api-examples/page_sidebar/app-express.py
@@ -1,8 +1,7 @@
 import matplotlib.pyplot as plt
 import numpy as np
 
-from shiny import render
-from shiny.express import input, ui
+from shiny.express import input, render, ui
 
 ui.page_opts(page_fn=page_fixed)
 

diff --git a/shiny/api-examples/sidebar/app-express.py b/shiny/api-examples/sidebar/app-express.py
@@ -1,5 +1,4 @@
-from shiny import render
-from shiny.express import input, ui
+from shiny.express import input, render, ui
 
 ui.page_opts(fillable=True)