Skip to content

Commit

Permalink
Change page_sidebar() and page_navbar() to default to `fillable=F…
Browse files Browse the repository at this point in the history
…alse` (#990)
  • Loading branch information
wch authored Jan 10, 2024
1 parent 05de458 commit b0582f1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [UNRELEASED]

### Breaking Changes

* Closed #938: `page_sidebar()` and `page_navbar()` now use `fillable=False` by default. (#990)

### New features

Expand Down
4 changes: 2 additions & 2 deletions shiny/ui/_page.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def page_sidebar(
sidebar: Sidebar,
*args: TagChild | TagAttrs,
title: Optional[str | Tag | TagList] = None,
fillable: bool = True,
fillable: bool = False,
fillable_mobile: bool = False,
window_title: str | MISSING_TYPE = MISSING,
lang: Optional[str] = None,
Expand Down Expand Up @@ -116,7 +116,7 @@ def page_navbar(
sidebar: Optional[Sidebar] = None,
# Only page_navbar gets enhanced treatement for `fillable`
# If an `*args`'s `data-value` attr string is in `fillable`, then the component is fillable
fillable: bool | list[str] = True,
fillable: bool | list[str] = False,
fillable_mobile: bool = False,
gap: Optional[CssUnit] = None,
padding: Optional[CssUnit | list[CssUnit]] = None,
Expand Down

0 comments on commit b0582f1

Please sign in to comment.