We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
None of the other methods have verbs at the end. To make the names consistent, I propose:
Accordion methods:
accordion()
accordion_panel()
accordion_panel_close()
accordion_panel_open()
accordion_panel_insert()
accordion_panel_remove()
accordion_panel_set()
update_accordion_panel()
update_accordion_panel(open = False)
update_accordion_panel(open = True)
update_accordion(open=)
update_accordion()
_panel()
toggle_accordion(values = Union[list[str], None])
values=None
No adjustments to accordion_panel_insert() or accordion_panel_remove()
cc @cpsievert @gadenbuie
The text was updated successfully, but these errors were encountered:
I wrote up some thoughts in this area in rstudio/bslib#706.
Sorry, something went wrong.
I would be open to trying to fit everything as verb first.
shiny.experimental.ui
shiny.ui
toggle_
layout_sidebar(sidebar)
page_sidebar(sidebar)
schloerke
Successfully merging a pull request may close this issue.
None of the other methods have verbs at the end. To make the names consistent, I propose:
Accordion methods:
accordion()
accordion_panel()
accordion_panel_close()
accordion_panel_open()
accordion_panel_insert()
accordion_panel_remove()
accordion_panel_set()
update_accordion_panel()
accordion_panel_close()
update_accordion_panel(open = False)
accordion_panel_open()
update_accordion_panel(open = True)
accordion_panel_set()
update_accordion(open=)
update_accordion_panel()
update_accordion()
_panel()
as it's really updating the accordion, not a single accordion paneltoggle_accordion(values = Union[list[str], None])
values=None
, toggles all accordion panels. Otherwise, toggle the specified panelsNo adjustments to
accordion_panel_insert()
oraccordion_panel_remove()
cc @cpsievert @gadenbuie
The text was updated successfully, but these errors were encountered: