Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api!: Move most methods from shiny.experimental.ui into shiny.ui; Deprecate most of shiny.experimental.ui #753

Merged
merged 65 commits into from
Oct 19, 2023
Merged

api!: Move most methods from shiny.experimental.ui into shiny.ui; Deprecate most of shiny.experimental.ui #753

merged 65 commits into from
Oct 19, 2023

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Oct 6, 2023 •
edited
Loading

Goal:
Move almost everything (if not everything), out of shiny.experimental.ui and into shiny.ui. Rearrange function locations as necessary to be pythonic. Deprecate every previously existing method in shiny.experiemental.ui that was ported.

Method to not port:

  • Valuebox's showcase methods. This API will change in the near future
  • Card's card_body() method. It should either be necessary or not. Currently going with not, therefore skipping it from the public API.

Overarching Tasks:

  • Port from shiny.experimental.ui to shiny.ui
    • Add deprecated methods for shiny.experimental.ui
  • Move api-examples from ./shiny/experimental/api-examples to ./shiny/api-examples
  • Update e2e tests
  • Do not use "deprecated experimental methods"
  • Documentation
    • Update method documentation to not use experimental
    • Update quartodoc's config to expose newly ported methods
    • Remove experimental methods from quartodoc's config

Followup PRs:

@schloerke schloerke self-assigned this Oct 6, 2023
@schloerke
Move consolidate_attrs fn
40b3458
@schloerke
Move CardItem, card() / card_impl(), card_header(), and `card…
b62ccc1 
…_footer()`
@schloerke
Move layout_column_wrap
3f9a64c
@schloerke
Create _valuebox.py
0860669
@schloerke
Update X deprecated
e04e706
@schloerke
Port X navs w/ sidebar
d33be85
@schloerke
First big pass at removing shiny.ui._x._sidebar and porting `shiny.…
29da988 
…experimental.ui._sidebar` to `shiny.ui._sidebar`
@schloerke
port X output methods who gained fill and fillable params
02aa09c
@schloerke
Port X page methods: page_sidebar, page_fillable, and page_navbar enh…
9720449 
…ancements
@schloerke
Move fill api-examples. Update fill docs
4625756
@schloerke
First pass at updating shiny.ui.__init__.py
34d1362
@schloerke
Very rough draft of changelog updates
176434c
@schloerke
Update htmldeps to be in three files. Remove X htmldeps; Fix textarea…
3714ab6 
… autoresize to resize on load.
@schloerke
Remove unused sass files
6d8f504
@schloerke
Update some examples to not use X and import from shiny.ui
a13404f
@schloerke
Move more X api-examples. Remove unnecessary `from __future__ import …
8952355 
…annotations`
wch
wch requested changes Oct 17, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
docs/_quartodoc.yml Outdated Show resolved Hide resolved
docs/_quartodoc.yml Outdated Show resolved Hide resolved
docs/_quartodoc.yml Outdated Show resolved Hide resolved
js/build.ts Outdated Show resolved Hide resolved
js/text-area/textarea-autoresize.ts Outdated Show resolved Hide resolved
js/package.json Outdated Show resolved Hide resolved
shiny/experimental/ui/__init__.py Outdated Show resolved Hide resolved
wch
wch requested changes Oct 17, 2023
View reviewed changes
shiny/ui/_html_deps_external.py Show resolved Hide resolved
shiny/ui/__init__.py Show resolved Hide resolved
shiny/ui/__init__.py Show resolved Hide resolved
shiny/ui/_card.py Show resolved Hide resolved
shiny/ui/_input_text.py Outdated Show resolved Hide resolved
shiny/ui/_output.py Outdated Show resolved Hide resolved
shiny/ui/_page.py Outdated Show resolved Hide resolved
shiny/ui/_sidebar.py Show resolved Hide resolved
shiny/ui/_sidebar.py Outdated Show resolved Hide resolved
shiny/ui/fill/_fill.py Show resolved Hide resolved
schloerke and others added 20 commits October 18, 2023 12:18
@schloerke
Update CHANGELOG.md
c10aee4
@schloerke
Update comments
a92384a
@schloerke
Do not deprecate shiny.experimental.ui.WrapperCallable
6267309
@schloerke
Gut fill_carrier methods
80d6ad2
@schloerke
ui.css_unit -> ui.css
8c22abb
@schloerke
Update package.json
7660ea5
@schloerke
Remove console.log() calls
d0fe671
@schloerke
More API comments for followup PR
bb8cf93
@schloerke
Comments for htmldeps files
3f323a5
@schloerke
Update _input_text.py
79157c3
@schloerke @wch
typo
e121b9b 
Co-Authored-By: Winston Chang <[email protected]>
@schloerke
Clearer code logic
6031571
@schloerke
Make fillable calls consistent with container class first, item second
d4a5955
@schloerke
Update _navs.py
1010cee
@schloerke
Consolidate layout_sidebar(sidebar=, *args) into `layout_sidebar(*a…
0816510 
…rgs)`. Added notes for other functions
@schloerke
Moved methods into UI Layout and moved update sections farther down
bb1eb90
@schloerke
Fix sidebar bugs
1738a1b
@schloerke
Update _fill.py
e6946d5
@schloerke
Make JS build type "esm"
89b7d7a
@schloerke
Add comments
89504b8
@schloerke schloerke marked this pull request as ready for review October 18, 2023 23:58
@schloerke schloerke merged commit 1095566 into main Oct 19, 2023
23 of 24 checks passed
@schloerke schloerke deleted the x_into_main branch October 19, 2023 00:57
schloerke added a commit that referenced this pull request Oct 19, 2023
@schloerke
Merge branch 'main' into autoreload-tweaks
1421c12 
* main:
  api!: Move most methods from `shiny.experimental.ui` into `shiny.ui`; Deprecate most of `shiny.experimental.ui` (#753)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpsievert cpsievert cpsievert left review comments

@wch wch wch requested changes

Assignees

@schloerke schloerke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schloerke @wch @cpsievert