Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat): Use wrap: pre so that "text" messages appear as-written #1778

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

gadenbuie
Copy link
Collaborator

When [content_type="text"] we should echo the message exactly as it was written.

@gadenbuie gadenbuie requested a review from cpsievert November 20, 2024 15:24
@cpsievert
Copy link
Collaborator

I'd be curious to see how you're using content_type="text" since we don't really expose this at the moment, but seems OK to me.

@gadenbuie
Copy link
Collaborator Author

I'd be curious to see how you're using content_type="text" since we don't really expose this at the moment, but seems OK to me.

Manually, but in line with #1780 I think it should be possible to pick this content type. If you did, though, it'd currently not be what you expect.

@gadenbuie
Copy link
Collaborator Author

Failures are transient in airmass example and un-related, merging.

@gadenbuie gadenbuie merged commit ba97d6d into main Nov 22, 2024
37 of 41 checks passed
@gadenbuie gadenbuie deleted the chat/text-message-wrapping branch November 22, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants