Add ui.MarkdownStream
#1782
Draft
Add ui.MarkdownStream
#1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcheng5
reviewed
Nov 26, 2024
jcheng5
reviewed
Nov 26, 2024
| from shiny import App, ui | ||
|
|
||
| app_ui = ui.page_fluid( | ||
| ui.markdown_stream_ui("shiny-readme"), |
There was a problem hiding this comment.
Would ui.output_markdown_stream be more consistent with our past naming, perhaps? (I think of Chat as a special case because it's equal parts output and input)
There was a problem hiding this comment.
Ah yes, agreed, thanks.
cpsievert
force-pushed
the
markdown-stream-component
branch
from
026867b to
ba86904
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the streaming markdown capabilities of
ui.Chat()into another component:ui.MarkdownStream(). See the new files for example usage:shiny/api-examples/MarkdownStream/app-express.pyshiny/api-examples/MarkdownStream/app-core.pyBy pulling out the markdown rendering aspect of
chat.tsinto a more reusable web component, it not only allows us to fairly easily support an additional component, but I can also re-use it forchatlas, which will be a big improvement over therichconsole for a web-based settings.TODO
ui.Chat()ui.MarkdownStream()shinychat.shinychatwill need to be updated to pull in additional JS/CSS files