Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api)!: Rename ui.navset_pill_card -> ui.navset_card_pill and ui.navset_tab_card -> ui.navset_card_tab #681

Merged
merged 5 commits into from
Aug 17, 2023

Conversation

schloerke
Copy link
Collaborator

Fixes #492

Currently not renaming nav to nav_panel.

@schloerke schloerke marked this pull request as ready for review August 16, 2023 15:48
@schloerke schloerke requested a review from wch August 16, 2023 15:48
@schloerke schloerke self-assigned this Aug 16, 2023
* main:
  Consolidate all testing into `tests/` folder (#683)
@schloerke schloerke changed the title Rename ui.navset_pill_card -> ui.navset_card_pill and ui.navset_tab_card -> ui.navset_card_tab chore(api)!: Rename ui.navset_pill_card -> ui.navset_card_pill and ui.navset_tab_card -> ui.navset_card_tab Aug 17, 2023
@schloerke schloerke merged commit 57f6ba5 into main Aug 17, 2023
@schloerke schloerke deleted the navset_docs_names branch August 17, 2023 20:26
schloerke added a commit that referenced this pull request Aug 22, 2023
* main:
  feat(Session): Make Session on_flush() and on_flushed() accept async functions (#693)
  Make data frame selection return row numbers, not pandas index value (#677)
  chore(api)!: Rename `ui.navset_pill_card` -> `ui.navset_card_pill` and `ui.navset_tab_card` -> `ui.navset_card_tab` (#681)
  Consolidate all testing into `tests/` folder (#683)
  Fix pyright error (#678)
  Make model score app work on Connect/Shinyapps.io (#657)
  Suppress type check for read_csv
  Synchonize input_file examples
  More realistic file import example (#582)
  Make flaky dataframe test have larger timeout (#675)
  Wrap bare value box value in `p` tag (#668)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated nav/navset API names
2 participants