Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate the requirements.txt file before deploys #998

Merged
merged 6 commits into from
Jan 16, 2024

Conversation

karangattu
Copy link
Collaborator

@karangattu karangattu commented Jan 12, 2024

  1. We were running into a problem when duplicate entries in the requirements.txt by parallel deploys from shinyapps.io and connect caused issues. This change not truncates the files before copying over the packages from app_requirements.txt
  2. Add tests to check if the apps are correctly up and running that shiny create allows (js ones excluded for now)
  3. Refactor the logic to check for js-errors in example apps tests to make it a function for reusability.
  4. Pin version of fast api to get around connect deployment issues - Temporary fix
    Note: Build step still failing due to Restore RenderFunction, RenderFunctionSync, and RenderFunctionAsync #1003

@karangattu karangattu marked this pull request as ready for review January 12, 2024 21:09
@karangattu karangattu requested a review from schloerke January 12, 2024 21:09
@karangattu karangattu merged commit 1f77650 into main Jan 16, 2024
26 checks passed
@karangattu karangattu deleted the deploys-truncate-requirements.txt-file branch January 16, 2024 20:59
schloerke added a commit that referenced this pull request Jan 19, 2024
* main: (26 commits)
  api!: Merge RendererBase class into Renderer (#1032)
  chore(render.display): Improve error message (#1020)
  `express.ui.page_opts(title = ...)` now always generates a header (#1016)
  api!: `Renderer.auto_output_ui()` drops `id` arg. Make `RendererBase.output_id` a non-namespaced value. (#1030)
  fix(page_sidebar): Add semicolon to end style declaration (#1027)
  chore: Remove experimental from app (#1028)
  chore: Expose `render.renderer.RendererBaseT` and do not require `| None` when defining Renderer types (#1026)
  bug: Restore legacy renderers while packages transition (#1023)
  Update deploy test apps to use render.code
  Update changelog
  Provide useful message in Express when `input` was not imported (#994)
  Calculate coordinate mapping after drawing figure (#999)
  Remove `express.ui.output_*` functions, add `shiny.express.render` (#1018)
  fix: Do not allow for renderer's to be given to reactive effects (#1017)
  Truncate the requirements.txt file before deploys (#998)
  Update changelog
  Fixes for flake8 (#1012)
  Pin starlette version below 0.35 (#1009)
  Remove shiny express warning
  Cause RecallContextManagers to run when used without `with` (#992)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants