Show status when downloading assets #41
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so that the asset download status is printed, and updated every 1 second. This is helpful when on a not-super-fast internet connection so that the user has an idea what is happening and how long they will have to wait.
It adds an option
--no-status
to disable the displaying of the status. However, as of right now, that option is only available when runningshinylive assets download
. It's not there if you runshinylive export ...
and the assets are automatically downloaded. I think that's OK, since I believe it would be an unusual case where someone wants to runshinylive export
and suppress the status, and for those use cases, they could just runshinylive assets download --no-status
first.