Cleanup orphaned widget models #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
force-pushed
the
cleanup-orphaned-widgets
branch
4 times, most recently
from
30f9b46 to
ccb676b
Compare
…ated as a side-effect of a output render) when they're no longer needed (i.e., the next time the output renders or if the session closes)
cpsievert
force-pushed
the
cleanup-orphaned-widgets
branch
from
ccb676b to
eedb1b8
Compare
cpsievert
force-pushed
the
cleanup-orphaned-widgets
branch
from
a6886fb to
63d44d9
Compare
cpsievert
commented
Nov 18, 2024
Comment on lines
-103
to
-108
| // Don't allow more than one .lmWidget container, which can happen | ||
| // when the view is displayed more than once | ||
| // TODO: It's probably better to get view(s) from m.views and .remove() them | ||
| while (el.childNodes.length > 1) { | ||
| el.removeChild(el.childNodes[0]); | ||
| } |
There was a problem hiding this comment.
No longer needed now that we're properly closing the model (which deletes the view)
cpsievert
force-pushed
the
cleanup-orphaned-widgets
branch
3 times, most recently
from
8992aec to
2f952ed
Compare
cpsievert
force-pushed
the
cleanup-orphaned-widgets
branch
from
2f952ed to
b10e675
Compare
jcheng5
reviewed
Nov 19, 2024
jcheng5
reviewed
Nov 19, 2024
jcheng5
reviewed
Nov 19, 2024
jcheng5
reviewed
Nov 19, 2024
|
In case I didn't say this out loud when we met today, LGTM after you address those last little comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #166