Ensure a session context is present when widgets are closed #171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #170
The reason this didn't come up in testing is because I was using an app that used
invalidate_later()
for invalidation, and it that case, the session is actually present.on_invalidate()
. Whereas, if a reactive effect gets invalidated in the normal way, it apparently doesn't exist at.on_invalidate()
time.This seems like a bug in Shiny, but since this is such a bad regression in shinywidgets, I'm gonna do this patch fix for now: