Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsconnect-python doesn't support no_proxy variable #400

Closed
greenjune-ship-it opened this issue Apr 4, 2023 · 1 comment · Fixed by #488
Closed

rsconnect-python doesn't support no_proxy variable #400

greenjune-ship-it opened this issue Apr 4, 2023 · 1 comment · Fixed by #488
Assignees

Comments

@greenjune-ship-it
Copy link

Dear Team,

I'm raising the issue regarding the feature request.

The issue

We are observing that rsconnect-python package doesn't support no_proxy environment variables.

Desired feature

rsconnect-python package should support both HTTP_PROXY, HTTPS_PROXY and no_proxy variables in order to be able to access external and internal resources from the same environment.

Justification

It is important for big production environments that restrict access to internal services with configured proxy variables. Right now users should unset HTTPS_PROXY before deployment,

Additional notes

I see that rsconnect-python ignores https_proxy and https_proxy lowercase variables. Is it a feature or it is better to fix this behaviour?

Thank you for your consideration, hope to hear from you soon!

Best regards,
Yulia

@sergeytalash
Copy link

Looks like NO_PROXY environment variable issue is solved by my commit #480
Waiting for implementation.

@mmarchetti mmarchetti mentioned this issue Oct 3, 2023
5 tasks
@mmarchetti mmarchetti self-assigned this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants