Add NO_PROXY support #488
Merged
Add NO_PROXY support #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
tdstein
reviewed
Oct 4, 2023
| @@ -75,7 +75,12 @@ def _create_ssl_connection(host_name, port, disable_tls_check, ca_data): | |||
| """ | |||
| if ca_data is not None and disable_tls_check: | |||
| raise ValueError("Cannot both disable TLS checking and provide a custom certificate") | |||
| _, _, proxyHost, proxyPort = _get_proxy() | |||
|
|
|||
| no_proxy = os.environ.get("no_proxy", os.environ.get("NO_PROXY", "#")) | |||
There was a problem hiding this comment.
Why is the default value '#'?
There was a problem hiding this comment.
It won't ever match a hostname. Since the check is endswith, an empty string would be interpreted as matching all hosts.
tdstein
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for NO_PROXY. It's based on #480, but on a local branch.
Intent
Fixes #400
Type of Change
Directions for Reviewers
Deploy content:
Checklist