Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use get application API when calling get_rstudio_app_info #468

Merged
merged 7 commits into from
Sep 8, 2023

Conversation

mslynch
Copy link
Contributor

@mslynch mslynch commented Aug 29, 2023

Intent

Resolves #464.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change

Approach

With shinyapps.io, app_id will be an application id in get_rstudio_app_info, so we need to use the GET application API.

Automated Tests

Directions for Reviewers

  1. Ensure the rsconnect-python folder is gone: rm -rf ./my-shiny-app/rsconnect-python
  2. Deploy to shinyapps.io: rsconnect deploy shiny --name $YOUR_CRED_NAME ./my-shiny-app/
  3. Redeploy to shinyapps.io: rsconnect deploy shiny --app-id $YOUR_APP_ID --name $YOUR_CRED_NAME ./my-shiny-app/

Checklist

  • I have updated CHANGELOG.md to cover notable changes.
  • I have updated all related GitHub issues to reflect their current state.

@github-actions
Copy link

github-actions bot commented Aug 29, 2023

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
4287 2777 65% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/api.py 68% 🟢
TOTAL 68% 🟢

updated for commit: a46722f by action🐍

@mslynch mslynch marked this pull request as ready for review September 5, 2023 16:53
@mslynch mslynch requested a review from mmarchetti September 5, 2023 16:54
@mslynch mslynch merged commit f8e2cac into master Sep 8, 2023
12 of 13 checks passed
@mslynch mslynch deleted the shinyapps-target-app-id-fix branch September 8, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need ability to overwrite existing shiny apps on shinyapps.io
2 participants