Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send content category to Posit Cloud API #478

Open
wants to merge 12 commits into
base: refactor-manifest
Choose a base branch
from

Conversation

mslynch
Copy link
Contributor

@mslynch mslynch commented Sep 11, 2023

Intent

Resolves #474. Dependent on #477.

Type of Change

Enhancement

Approach

Includes a change to the functions passed to make_bundle to return the Manifest and the bundle file bytes so that can pass the content category to Posit Cloud's API.

Automated Tests

Updated some tests to handle the case where content_category is non-None.

Directions for Reviewers

Deploy and redeploy Quarto content to Posit Cloud.

Checklist

  • I have updated CHANGELOG.md to cover notable changes. probably not notable enough for a changelog entry
  • I have updated all related GitHub issues to reflect their current state.

@mslynch mslynch changed the base branch from master to refactor-manifest September 11, 2023 15:40
@mslynch mslynch changed the base branch from refactor-manifest to master September 11, 2023 15:51
@mslynch mslynch marked this pull request as ready for review September 11, 2023 16:12
@mslynch mslynch force-pushed the content-category-cloud-2 branch from 06cb76b to 54e0d50 Compare September 11, 2023 16:20
@github-actions
Copy link

github-actions bot commented Sep 11, 2023

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
4268 2761 65% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/actions.py 33% 🟢
rsconnect/api.py 68% 🟢
rsconnect/bundle.py 80% 🟢
rsconnect/main.py 55% 🟢
TOTAL 59% 🟢

updated for commit: 04affc0 by action🐍

@mslynch mslynch changed the base branch from master to refactor-manifest September 11, 2023 17:39
@mslynch
Copy link
Contributor Author

mslynch commented Sep 13, 2023

Tested this using a rendered Rmd (rsconnect deploy html) and a quarto doc (`rsconnect deploy quarto).

kgartland-rstudio and others added 3 commits September 18, 2023 13:43
Seeing warnings in test runs stating that license_file will be deprecation next month:
```
integration-testing-client-1   |         The license_file parameter is deprecated, use license_files instead.
integration-testing-client-1   | 
integration-testing-client-1   |         By 2023-Oct-30, you need to update your project and remove deprecated calls
integration-testing-client-1   |         or your builds will no longer be supported.
integration-testing-client-1   | 
integration-testing-client-1   |         See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details.
integration-testing-client-1   |    
```

updating to use `license_files` instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set content_category on static outputs and revisions
4 participants