-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
send content category to Posit Cloud API #478
Open
mslynch
wants to merge
12
commits into
refactor-manifest
Choose a base branch
from
content-category-cloud-2
base: refactor-manifest
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mslynch
force-pushed
the
content-category-cloud-2
branch
from
September 11, 2023 16:20
06cb76b
to
54e0d50
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Pin pypa GHA to a supported release version
omar-rs
approved these changes
Sep 11, 2023
Tested this using a rendered Rmd ( |
Seeing warnings in test runs stating that license_file will be deprecation next month: ``` integration-testing-client-1 | The license_file parameter is deprecated, use license_files instead. integration-testing-client-1 | integration-testing-client-1 | By 2023-Oct-30, you need to update your project and remove deprecated calls integration-testing-client-1 | or your builds will no longer be supported. integration-testing-client-1 | integration-testing-client-1 | See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details. integration-testing-client-1 | ``` updating to use `license_files` instead.
Use license_files in setup.cfg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Resolves #474. Dependent on #477.
Type of Change
Enhancement
Approach
Includes a change to the functions passed to
make_bundle
to return the Manifest and the bundle file bytes so that can pass the content category to Posit Cloud's API.Automated Tests
Updated some tests to handle the case where
content_category
is non-None.Directions for Reviewers
Deploy and redeploy Quarto content to Posit Cloud.
Checklist