Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit inline help to correctly list Cloud and shinyapps.io support #482

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mbaynton
Copy link

@mbaynton mbaynton commented Sep 18, 2023

Intent

Fixes #481

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change

Approach

Make the kinds of systems that are supported (Connect, Cloud, shinyapps.io) a property of AppModes

Automated Tests

I'm not a regular contributor to this repo and wanted to do more than chuck an issue over the fence. Happy to add tests if someone familiar with rsconnect-python wants to suggest specific kinds of tests to add.

Directions for Reviewers

Run rsconnect deploy. Verify that

  • All deploy subcommands listed in help are advertised as supported by Connect
  • API, bokeh, dash, fastapi, html, quarto, shiny, and streamlit are also advertised as supported by Cloud
  • shiny is also advertised as supported by shinyapps.io.

Repeat for rsconnect deploy api, rsconnect deploy shiny etc. (check full command help description)

Checklist

  • I have updated CHANGELOG.md to cover notable changes.
  • I have updated all related GitHub issues to reflect their current state.

@github-actions
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
4305 2795 65% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/main.py 55% 🟢
rsconnect/models.py 78% 🟢
TOTAL 66% 🟢

updated for commit: 08e2eb6 by action🐍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rsconnect deploy --help is wrong? (Suggests shinyapps.io supports non-shiny apps)
1 participant