Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Posit logo to docs footer #489

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Add Posit logo to docs footer #489

merged 6 commits into from
Oct 20, 2023

Conversation

mmarchetti
Copy link
Contributor

@mmarchetti mmarchetti commented Oct 4, 2023

This PR adds a Posit logo/link to the docs footer, similar to https://github.com/rstudio/connect/pull/24572.

Directions for Reviewers

Build the docs and view them.

cd docs/site
make -C .. build && python -m http.server

@mmarchetti
Copy link
Contributor Author

Fixes #490

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
4231 2775 66% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: c16c9b1 by action🐍

@mmarchetti mmarchetti linked an issue Oct 4, 2023 that may be closed by this pull request
@mmarchetti mmarchetti requested a review from wydsith October 16, 2023 18:17
wydsith
wydsith previously approved these changes Oct 16, 2023
@wydsith wydsith dismissed their stale review October 19, 2023 19:44

logo only on index, need to update for addition to other pages, we should remove logo from header

I made a change to the path
It appears that this vertically aligns the header links for the release notes and help links
@mmarchetti mmarchetti removed the hold label Oct 20, 2023
@mmarchetti mmarchetti requested a review from wydsith October 20, 2023 14:49
@mmarchetti mmarchetti merged commit a3a0a00 into master Oct 20, 2023
14 checks passed
@mmarchetti mmarchetti deleted the mm-docs-log branch October 20, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Posit logo in rsconnect-python docs footer
3 participants