Remove Conda flag #500
Merged
Remove Conda flag #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
mmarchetti
approved these changes
Oct 17, 2023
CONTRIBUTING.md
Outdated
| @@ -22,7 +22,7 @@ cd rsconnect-python | |||
| python3 -m venv .venv | |||
| # Activate the virtual environment | |||
| source .venv/bin/activate | |||
| # install our requirements into the virtual environment | |||
| # install our requirements into the virtual environment based | |||
There was a problem hiding this comment.
nit: seems like this might have been incompletely edited
| @@ -0,0 +1,361 @@ | |||
| ### GNU GENERAL PUBLIC LICENSE | |||
There was a problem hiding this comment.
This directory seems like it should be gitignored.
Weird. I run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Experimental support for Conda environment was added to rsconnect-python. Connect does not support restoring Conda environments. This PR will remove the Conda references from rsconnect-python.
resolves: #412
Type of Change
Approach
condain all forms through the codebase and removed appropriate parameters and functions.Directions for Reviewers
Per conversation w/ Mike:
Checklist