Compatibility with previous saved rsconnect.environment modules #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
mmarchetti
approved these changes
Oct 19, 2023
|
Verified fixed! I tried reproducing with the same I also created a fresh python environment and installed this build. I referenced the new python executable in the |
kgartland-rstudio
approved these changes
Oct 19, 2023
sagerb
deleted the
sagerb-compatible-with-older-rsconnect-environments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
reconnect-python saves an
rsconnect.environmentmodule within each python installation it executes from. With the removal ofcondosupport, we need to be compatible with entries saved within those older installations.Resolves #510
Type of Change
Approach
the
environment.py::MakeEnvironmentmethod is passed named arguments from attributes saved withinthe
rsconnect.environmentmodule. Rather than add acondaparameter, I've chosen to catch allunmatched arguments with a wild-card catch-all.
Automated Tests
None impacted
Directions for Reviewers
This should be tested against an older python installation which had an older version of reconnect-python used with it. It should also be tested against a new installation in which the user has never used rsconnect-python.
Checklist