-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for shiny express apps #521
Conversation
That there is a type-checking error in CI -- this issue actually existed in the code before but wasn't picked up on by the type checker because it was obscured by passing in the The problem is that in Looking at the code, I suspect that it should be |
I also didn't update the changelog because there wasn't a section since the previous release. Should I add one? |
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
Tests for deploying shiny express apps via the rsconnect-python package to connect will be added in the next week. |
The tests for this will live in py-shiny and will be merged once rsconnect main has the PR code. All manual tests are done and the feature works as expected. PR can be merged. |
Intent
This PR adds support for Shiny express apps.
Type of Change
Approach
The main change was pretty straightforward. It involves copying the contents of one file from the shiny package, and then adding three lines of code that change the
entrypoint
and set an environment variable.However, there were more changes that I made, with some help from @mmarchetti. The use of
kwargs = locals()
, and passing thekwargs
along toRSConnectExecutor(**kwargs)
was confusing and caused some problems, so I made the arguments explicit.Automated Tests
I didn't add any tests.
Directions for Reviewers
This will require a close look to make sure that the
extra_args
being passed toRSConnectExecutor()
contain the correct items. With the previous code, it was extremely difficult to tell which arguments from thekwargs
were meant to go toRSConnectExecutor()
, and which ones just happened to be along for the ride.Checklist