Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove RSConnectClient.app_publish(); obsolete workflow (Connect 1.7.6+) #606

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

aronatkins
Copy link
Collaborator

Intent

This function is uncalled. Connect removed needs_config in 1.7.6.

There are no callers to app_publish().

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change

Approach

Automated Tests

Directions for Reviewers

Checklist

  • I have updated CHANGELOG.md to cover notable changes.
  • I have updated all related GitHub issues to reflect their current state.

Copy link

github-actions bot commented Jun 26, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
4804 3564 74% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/api.py 71% 🟢
TOTAL 71% 🟢

updated for commit: ae98f0f by action🐍

@aronatkins aronatkins force-pushed the aron-no-explicit-publish branch from b885d41 to ae98f0f Compare June 27, 2024 15:12
@aronatkins aronatkins merged commit b937579 into main Jun 27, 2024
15 checks passed
@aronatkins aronatkins deleted the aron-no-explicit-publish branch June 27, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants