Fix escaping for cmd.exe: either quote or escape individual special…

… characters (#49)

CHANGELOG.md

@@ -11,6 +11,7 @@
   - **Create ShinyLive Link from Active File** creates a Shinylive link from the active file (Command Palette).
   - **Create ShinyLive Link from Selected Files** creates a Shinylive link from the selected files or directories in the right-click context menu of the File Explorer.
   - **Save App from Shinylive Link** saves an app and its files from a Shinylive link (Command Palette).
+- Fixed a bug that would doubly-escape paths with spaces when launching Shiny apps on Windows via `cmd.exe`. ([#46](https://github.com/posit-dev/shiny-vscode/issues/46))
 
 ## 0.1.6
 

src/shell-utils.ts

@@ -32,9 +32,17 @@ function escapeStyle(terminal: vscode.Terminal): EscapeStyle {
 export function escapeArg(arg: string, style: EscapeStyle): string {
   switch (style) {
     case "cmd":
-      // For cmd.exe, double quotes are used to handle spaces, and carets (^) are used to escape special characters.
-      const escaped = arg.replace(/([()%!^"<>&|])/g, "^$1");
-      return /\s/.test(escaped) ? `"${escaped}"` : escaped;
+      // For cmd.exe, use double quotes if input includes spaces
+      if (/\s/.test(arg)) {
+        if (!arg.includes('"')) {
+          return `"${arg}"`;
+        }
+        // Escape double quotes by doubling them
+        return `"${arg.replace(/"/g, '"""')}"`;
+      }
+
+      // Carets (^) are used to escape special characters in unquoted strings.
+      return arg.replace(/([()%!^"<>&|])/g, "^$1");
 
     case "ps":
       if (!/[ '"`,;(){}|&<>@#[\]]/.test(arg)) {