Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for Shiny for R apps that use ui.R and friends #39

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

gadenbuie
Copy link
Collaborator

Fixes #38

Detects Shiny apps from files name ui.R, server.R, global.R and passes the directory containing the file to shiny::runApp() instead of the file path.

Note that we still require the word "shiny" to appear in the file contents in these cases, so sometimes server.R or global.R might not activate the extension. Users can still manually activate the "Run Shiny app" command in these cases.

@gadenbuie gadenbuie requested a review from jcheng5 April 23, 2024 19:20
@gadenbuie gadenbuie marked this pull request as ready for review April 23, 2024 19:20
@gadenbuie gadenbuie merged commit 2608eed into main Apr 26, 2024
1 check passed
@gadenbuie gadenbuie deleted the gadenbuie/fix/issue-38 branch April 26, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve support for ui.R and friends style apps
2 participants