Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add shiny.previewType configuration setting #40

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

gadenbuie
Copy link
Collaborator

Adds a new setting allowing users to choose whether the app should be opened internally, externally, or if no preview should be opened at all.

@gadenbuie gadenbuie requested a review from jcheng5 April 24, 2024 14:09
@gadenbuie gadenbuie added this to the v0.2.0 milestone Apr 24, 2024
package.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@jcheng5 jcheng5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that one string, LGTM

@gadenbuie gadenbuie merged commit e1237e3 into main Apr 26, 2024
1 check passed
@gadenbuie gadenbuie deleted the feat/setting-preview-type branch April 26, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants