Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't open blank page in external browser #52

Merged
merged 1 commit into from
May 2, 2024

Conversation

gadenbuie
Copy link
Collaborator

@gadenbuie gadenbuie commented May 1, 2024

We pre-load about:blank internally to clear the internal browser or signal that we're working on opening the Shiny app, but for external previews this step is unnecessary.

@gadenbuie gadenbuie requested review from jcheng5 and karangattu May 1, 2024 19:01
@gadenbuie gadenbuie mentioned this pull request May 1, 2024
@karangattu
Copy link

Tested on Workbench, Windows, MacOS (local) and GitHub Codespaces. The external preview now opens a new tab with the app. Note: This code does not have Shinylive capabilities. Use the artifacts from #44 to test that feature

Copy link

@karangattu karangattu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcheng5 jcheng5 merged commit e6d25f5 into main May 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants