Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R Package Prep #4

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

R Package Prep #4

wants to merge 10 commits into from

Conversation

gadenbuie
Copy link

  • Adds GitHub Actions to check the R package
  • Fills out DESCRIPTION
  • Small clean up of documentation, location of imports, etc. to follow usethis conventions
  • Generally gets the package ready for CRAN submission (if desired)

@gadenbuie gadenbuie changed the base branch from docs-r-package to main August 28, 2024 13:59
gadenbuie
gadenbuie commented Aug 28, 2024
View reviewed changes
.github/workflows/R-CMD-check.yaml
Comment on lines +3 to +6
on:
push:
branches: [main, master]
paths: ['r-package/**']
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to do something similar in .github/workflows/release.yml to avoid running Python checks unless the python-package files change.

Although there it's slightly more complicated because that workflow relies on tag pushes for publishing. (Otherwise I would have done that now.)

@gadenbuie gadenbuie requested a review from jcheng5 August 28, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcheng5 jcheng5 Awaiting requested review from jcheng5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gadenbuie