Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DOS issue on fixLineBuffer #65

Closed
wants to merge 1 commit into from

Conversation

baptistejamin
Copy link

As explained on #64 , there is a DOS issue with the fixLineBuffer function.

This patch fixes the issue.

Since we couldn't catch the exact mail content creating this issue, I added a test script that creates a very long line email: #64 (comment)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Baptiste Jamin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@titanism
Copy link

ping @andris9

@titanism
Copy link

The crisp folks fixing an issue we had for @forwardemail too, thanks many 🙏 🚀

@andris9 andris9 changed the title Fix catastrophic DOS issue on fixLineBuffer Fix DOS issue on fixLineBuffer Aug 20, 2024
@andris9
Copy link
Collaborator

andris9 commented Aug 20, 2024

@baptistejamin Thank you, but in order to merge the PR, I would have to ask you to sign the CLA as instructed in the comment above. If you are not able to, then let me know, and I'll implement a similar fix myself.

@baptistejamin
Copy link
Author

@andris9 You can do whatever you want with the PR

@andris9
Copy link
Collaborator

andris9 commented Aug 22, 2024

Fixed in https://github.com/postalsys/mailauth/releases/tag/v4.6.9
I was not able to use the PR without a CLA, but I implemented a similar fix.

@andris9 andris9 closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants