Treat unsupported URLs as specified in Driver#connect to avoid overwriting the "real" exception #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…writing the "real" exception
|
thanks, and i'll fix the CI |
|
Note that I added an optional second commit, dropping some bits of documentation that I found very confusing, because the mangling of the URL is an implementation detail and not visible to the user. At least to me it felt as if the documentation indicated something like a reference/out parameter, but Java is purely pass-by-value. Feel free to not merge that one, if I misunderstood something! |
|
@phillipross Thanks! |
|
@phillipross Hold on, I just found an issue with the change. I'll fix it! |
|
Welp, I can't reopen it. :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.