-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/Remove PovioKit dependency #30
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
95ce5be
Remove PovioKit dep from FB pckg.
borut-t e388eb0
Remove PovioKit dep from LinkedIn pckg.
borut-t fdc1b20
Ignore resolved file.
borut-t 93fb84c
Value type.
borut-t 70d9456
Remove macos support.
borut-t dd8a2bc
Headers update.
borut-t a3d9531
Move decoding to client.
borut-t File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
// | ||
// HttpClient.swift | ||
// PovioKitAuth | ||
// | ||
// Created by Borut Tomazin on 22/05/2024. | ||
// Copyright © 2024 Povio Inc. All rights reserved. | ||
// | ||
|
||
import Foundation | ||
|
||
struct HttpClient { | ||
func request<D: Decodable>( | ||
method: String, | ||
url: URL, | ||
headers: [String: String]?, | ||
decodeTo decode: D.Type, | ||
with decoder: JSONDecoder = .init() | ||
) async throws -> D { | ||
var urlRequest = URLRequest(url: url) | ||
tonikocjan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
urlRequest.httpMethod = method | ||
urlRequest.allHTTPHeaderFields = headers | ||
|
||
let (data, response) = try await URLSession.shared.data(for: urlRequest) | ||
|
||
if let httpResponse = response as? HTTPURLResponse, | ||
!(200...299).contains(httpResponse.statusCode) { | ||
throw NSError(domain: "HTTP Error", code: httpResponse.statusCode, userInfo: nil) | ||
} | ||
|
||
return try decoder.decode(decode, from: data) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
// | ||
// URL+PovioKitAuth.swift | ||
// PovioKitAuth | ||
// | ||
// Created by Borut Tomazin on 22/05/2024. | ||
// Copyright © 2024 Povio Inc. All rights reserved. | ||
// | ||
|
||
import Foundation | ||
|
||
extension URL: ExpressibleByStringLiteral { | ||
public init(stringLiteral value: String) { | ||
guard let url = URL(string: value) else { | ||
fatalError("Invalid URL string!") | ||
} | ||
self = url | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the HttpClient part of the LinkedIn folder? Can we move it out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's internal implementation only needed by LinkedIn target.