Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SHA256 for custom nonce as well #32

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Use SHA256 for custom nonce as well #32

merged 1 commit into from
Aug 29, 2024

Conversation

dejanskledar
Copy link
Collaborator

@dejanskledar dejanskledar commented Aug 20, 2024 •
edited
Loading

  • Convert the custom nonce to SHA256 as well

Fixes an issue, where setting custom nonce with Firebase and PovioKitAuth resulted in an error, saying that the nonce on FirebaseAuth and PovioKitAuth were not matching:

The nonce in ID Token "zyx" does not match the SHA256 hash of the raw nonce "zyx" in the request.

@dejanskledar dejanskledar requested review from borut-t and a team August 20, 2024 11:21
@dejanskledar dejanskledar self-assigned this Aug 20, 2024
@dejanskledar dejanskledar removed the request for review from borut-t August 20, 2024 11:22
EgzonArifi
EgzonArifi reviewed Aug 20, 2024
View reviewed changes
Copy link
Member

@EgzonArifi EgzonArifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you had the chance to test this change by pointing to this branch?

borut-t
borut-t approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@borut-t borut-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👌

@dejanskledar
Copy link
Collaborator Author

@EgzonArifi yes, works

@dejanskledar dejanskledar merged commit f4e932d into develop Aug 29, 2024
2 checks passed
@dejanskledar dejanskledar deleted the fix/nonce-fix branch August 29, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgzonArifi EgzonArifi EgzonArifi left review comments

@borut-t borut-t borut-t approved these changes

Assignees

@dejanskledar dejanskledar

Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dejanskledar @borut-t @EgzonArifi