Stwobackend prover skeleton #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature using the nightly toolchain only when required
…es to be build by nightly
…es to be build by nightly
…es to be build by nightly
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
related to [this PR](#1898) we need to change to nightly toolchain to integrate stwo I kept the toolchain related to riscv to be "nightly-2024-08-01" as it is handled separately in workflow, so I made the least change to make stwo integrate-able for now. fix some clippy issues about the comment format on some files. --------- Co-authored-by: chriseth <[email protected]>
Schaeff
reviewed
Oct 17, 2024
Co-authored-by: Thibaut Schaeffer <[email protected]>
georgwiese
reviewed
Oct 18, 2024
Co-authored-by: Georg Wiese <[email protected]>
Co-authored-by: Georg Wiese <[email protected]>
Co-authored-by: Georg Wiese <[email protected]>
leonardoalt
pushed a commit
that referenced
this pull request
Oct 18, 2024
related to [this PR](#1898) we need to change to nightly toolchain to integrate stwo I kept the toolchain related to riscv to be "nightly-2024-08-01" as it is handled separately in workflow, so I made the least change to make stwo integrate-able for now. fix some clippy issues about the comment format on some files. --------- Co-authored-by: chriseth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on Integrating
StwoThis PR makes incremental progress towards integrating the
stwoprover, refer to issue #1833 . It includes the following changes:Add
stwofeature toCargo.toml:The
Cargo.tomlfiles for thecli,pipeline, andbackendcomponents have been updated to include thestwofeature.Implement
StwoProverFactory:A skeleton structure for
StwoProverFactoryhas been introduced. This structure implements theBackendFactorytrait.Implement
StwoProver:Similarly, a skeleton implementation of
StwoProverhas been created, implementing theBackendtrait. .Commands to run:
# Run the project with the `stwo` feature cargo run --features stwo pil test_data/pil/fibonacci.pil -o output -f --field m31 --prove-with stwo