Single step processor. #2272
Open
Single step processor. #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
force-pushed
the
single_step_simple
branch
from
ad752f2 to
cce4375
Compare
georgwiese
reviewed
Dec 20, 2024
| let mut progress = false; | ||
|
|
||
| for id in &self.machine_parts.identities { | ||
| let row_offset = if id.contains_next_ref() { 0 } else { 1 }; |
There was a problem hiding this comment.
Hmm, this function does not look into intermediate definitions :/ So this would lead to a wrong result:
col foo = a + b';
foo = 2;
I think this should be fixed in a different PR, but maybe you could add a TODO?
Comment on lines
+76
to
+78
| // TODO also check that we completed all machine calls? | ||
| if unknown_witnesses.is_empty() { | ||
| Ok(witgen.code()) |
There was a problem hiding this comment.
Suggested change
| // TODO also check that we completed all machine calls? | |
| if unknown_witnesses.is_empty() { | |
| Ok(witgen.code()) | |
| if unknown_witnesses.is_empty() { | |
| assert_eq!(complete, self.machine_parts.identities.len()); | |
| Ok(witgen.code()) |
In this case, we'd expect all identities to complete, right? Because all cells are known?
BTW, we don't really need complete to store the row offset, as it is determined by id.contains_next_ref().
| impl<T: FieldElement> FixedEvaluator<T> for &SingleStepProcessor<'_, T> { | ||
| fn evaluate(&self, _var: &AlgebraicReference, _row_offset: i32) -> Option<T> { | ||
| // We can only return something here if the fixed column is constant | ||
| // in the region wer are considering. |
There was a problem hiding this comment.
Suggested change
| // in the region wer are considering. | |
| // in the region we are considering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.